lhotari commented on code in PR #25592:
URL: https://github.com/apache/pulsar/pull/25592#discussion_r3154543531
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentDispatcherMultipleConsumers.java:
##########
@@ -362,17 +361,6 @@ public synchronized void readMoreEntries() {
// increment the counter for readMoreEntries calls, to track the
number of times readMoreEntries is called
readMoreEntriesCallCount++;
- // remove possible expired messages from redelivery tracker and
pending acks
- Position markDeletePosition = cursor.getMarkDeletedPosition();
- if (lastMarkDeletePositionBeforeReadMoreEntries != markDeletePosition)
{
Review Comment:
Another detail is that trimming (based on retention) doesn't currently
trigger the callbacks at all. Trimming is handled by the
org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl#internalTrimLedgers method
which calls advanceCursorsIfNecessary (btw. The javadoc of the
advanceCursorsIfNecessary method is misleading. For some reason, the javadoc
added in https://github.com/apache/pulsar/pull/10667/changes hasn't made it to
the code).
Trimming based on retention should also be handled before we can remove this
code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
