ng-galien commented on code in PR #25548:
URL: https://github.com/apache/pulsar/pull/25548#discussion_r3109892493
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpenTelemetryManagedCursorStats.java:
##########
@@ -115,6 +144,18 @@ public void close() {
batchCallback.close();
}
+ public void incrementPersistUnackedRangesTruncated(String managedLedger,
String cursor) {
+ persistUnackedRangesTruncated.add(1, Attributes.of(
+ AttributeKey.stringKey("managedLedger"), managedLedger,
+ AttributeKey.stringKey("cursor"), cursor));
+ }
+
+ public void incrementPersistBatchDeletedIndexesTruncated(String
managedLedger, String cursor) {
+ persistBatchDeletedIndexesTruncated.add(1, Attributes.of(
+ AttributeKey.stringKey("managedLedger"), managedLedger,
+ AttributeKey.stringKey("cursor"), cursor));
+ }
Review Comment:
done
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -3388,11 +3398,33 @@ private List<MessageRange>
buildIndividualDeletedMessageRanges() {
acksSerializedSize.addAndGet(messageRange.getSerializedSize());
rangeList.add(messageRange);
- return rangeList.size() <=
getConfig().getMaxUnackedRangesToPersist();
+ return true;
});
this.individualDeletedMessagesSerializedSize =
acksSerializedSize.get();
individualDeletedMessages.resetDirtyKeys();
+
+ if (truncated.booleanValue()) {
+ ledger.getFactory().getOpenTelemetryManagedCursorStats()
+
.incrementPersistUnackedRangesTruncated(ledger.getName(), name);
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
