ng-galien commented on code in PR #25548:
URL: https://github.com/apache/pulsar/pull/25548#discussion_r3104824791
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedCursorImpl.java:
##########
@@ -3388,11 +3398,32 @@ private List<MessageRange>
buildIndividualDeletedMessageRanges() {
acksSerializedSize.addAndGet(messageRange.getSerializedSize());
rangeList.add(messageRange);
- return rangeList.size() <=
getConfig().getMaxUnackedRangesToPersist();
+ return true;
});
this.individualDeletedMessagesSerializedSize =
acksSerializedSize.get();
individualDeletedMessages.resetDirtyKeys();
+
+ if (overflowed.booleanValue()) {
+
ledger.getFactory().getOpenTelemetryManagedCursorStats().incrementPersistOverflowRanges();
+ if (lastCursorDataFullyPersistable.compareAndSet(true, false))
{
+ int totalRanges = individualDeletedMessages.size();
+ log.warn()
Review Comment:
Ledger and cursor name are un the log constructor, is it sufficient?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
