nodece commented on code in PR #25536:
URL: https://github.com/apache/pulsar/pull/25536#discussion_r3091362855
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/SimpleProducerConsumerTest.java:
##########
@@ -3195,7 +3204,7 @@ public EncryptionKeyInfo getPublicKey(String keyName,
Map<String, String> keyMet
keyInfo.setKey(Files.readAllBytes(Paths.get(certFilePath)));
return keyInfo;
} catch (IOException e) {
- log.error("Failed to read certificate from {}",
certFilePath);
+ log.error().attr("certificate",
certFilePath).log("Failed to read certificate from");
Review Comment:
**`"certificate"` is misleading — the value is a file path, not a
certificate object.**
```suggestion
log.error().attr("certFilePath",
certFilePath).log("Failed to read certificate");
```
Same fix applies to line 3221.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
