nodece commented on code in PR #25536:
URL: https://github.com/apache/pulsar/pull/25536#discussion_r3091358292
##########
pulsar-broker/src/test/java/org/apache/pulsar/client/api/DeadLetterTopicTest.java:
##########
@@ -125,16 +123,17 @@ public void testDeadLetterTopicWithMessageKey() throws
Exception {
int totalReceived = 0;
do {
Message<byte[]> message = consumer.receive();
- log.info("consumer received message : {} {}",
message.getMessageId(), new String(message.getData()));
+ log.info().attr("receivedMessage",
message.getMessageId()).attr("value", new String(message.getData()))
Review Comment:
**`"receivedMessage"` is a verb phrase copied from the message text, not a
name for a `MessageId` value. This pattern repeats ~30 times in this file.**
```suggestion
log.info().attr("messageId",
message.getMessageId()).attr("data", new String(message.getData()))
```
All other `attr("receivedMessage", message.getMessageId())` occurrences
should be renamed to `"messageId"` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
