lhotari commented on PR #25520:
URL: https://github.com/apache/pulsar/pull/25520#issuecomment-4247208224

   > When the broker asks a client to close a consumer, if the `CloseConsumer` 
command does not reach the client, the client may keep the consumer alive 
locally while the broker has already removed it, leading to a silent 
inconsistent state.
   
   The change looks ok, but I have doubts whether there could be a scenario 
where the command doesn't reach the client and there's no other error / 
exception in the logs. Any unhandled exception would result in the connection 
being closed by [this code in 
exceptionCaught](https://github.com/apache/pulsar/blob/daa5f8db6ce4befeda0b71b6e1d4ae73f4d56c11/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java#L535-L553).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to