nodece opened a new pull request, #25520: URL: https://github.com/apache/pulsar/pull/25520
Main Issue: #25146 ### Motivation When the broker asks a client to close a consumer, if the `CloseConsumer` command does not reach the client, the client may keep the consumer alive locally while the broker has already removed it, leading to a silent inconsistent state. ### Modifications - update broker-side consumer close handling to close the whole connection when sending `CloseConsumer` fails - keep the existing protocol behavior for older clients that already fall back to closing the connection - add a broker test covering the failed `CloseConsumer` write path ### Verifying this change - [ ] Make sure that the change passes the CI checks. This change added tests and can be verified as follows: - Added a `ServerCnxTest` case for failed `CloseConsumer` writes to ensure the connection is closed ### Does this pull request potentially affect one of the following parts: - [ ] Dependencies (add or upgrade a dependency) - [ ] The public API - [ ] The schema - [ ] The default values of configurations - [ ] The threading model - [ ] The binary protocol - [ ] The REST endpoints - [ ] The admin CLI options - [ ] The metrics - [ ] Anything that affects deployment -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
