Denovo1998 commented on code in PR #25384:
URL: https://github.com/apache/pulsar/pull/25384#discussion_r3035280384


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/bucket/BucketDelayedDeliveryTracker.java:
##########
@@ -119,19 +122,55 @@ public 
BucketDelayedDeliveryTracker(AbstractPersistentDispatcherMultipleConsumer
                                         long minIndexCountPerBucket, long 
timeStepPerBucketSnapshotSegmentInMillis,
                                         int 
maxIndexesPerBucketSnapshotSegment, int maxNumBuckets)
             throws RecoverDelayedDeliveryTrackerException {
-        this(dispatcher, timer, tickTimeMillis, Clock.systemUTC(), 
isDelayedDeliveryDeliverAtTimeStrict,
+        this(new DispatcherDelayedDeliveryContext(dispatcher), timer, 
tickTimeMillis, Clock.systemUTC(),
+                isDelayedDeliveryDeliverAtTimeStrict, bucketSnapshotStorage, 
minIndexCountPerBucket,
+                timeStepPerBucketSnapshotSegmentInMillis, 
maxIndexesPerBucketSnapshotSegment, maxNumBuckets);
+    }
+
+    public 
BucketDelayedDeliveryTracker(AbstractPersistentDispatcherMultipleConsumers 
dispatcher,
+                                        Timer timer, long tickTimeMillis, 
Clock clock,
+                                        boolean 
isDelayedDeliveryDeliverAtTimeStrict,
+                                        BucketSnapshotStorage 
bucketSnapshotStorage,
+                                        long minIndexCountPerBucket, long 
timeStepPerBucketSnapshotSegmentInMillis,
+                                        int 
maxIndexesPerBucketSnapshotSegment, int maxNumBuckets)
+            throws RecoverDelayedDeliveryTrackerException {
+        this(new DispatcherDelayedDeliveryContext(dispatcher), timer, 
tickTimeMillis, clock,
+                isDelayedDeliveryDeliverAtTimeStrict, bucketSnapshotStorage, 
minIndexCountPerBucket,
+                timeStepPerBucketSnapshotSegmentInMillis, 
maxIndexesPerBucketSnapshotSegment, maxNumBuckets);
+    }
+
+    public BucketDelayedDeliveryTracker(String dispatcherName, ManagedCursor 
cursor,
+                                        Timer timer, long tickTimeMillis,
+                                        boolean 
isDelayedDeliveryDeliverAtTimeStrict,
+                                        BucketSnapshotStorage 
bucketSnapshotStorage,
+                                        long minIndexCountPerBucket, long 
timeStepPerBucketSnapshotSegmentInMillis,
+                                        int 
maxIndexesPerBucketSnapshotSegment, int maxNumBuckets)
+            throws RecoverDelayedDeliveryTrackerException {
+        this(new NoopDelayedDeliveryContext(dispatcherName, cursor), timer, 
tickTimeMillis, Clock.systemUTC(),
+                isDelayedDeliveryDeliverAtTimeStrict, bucketSnapshotStorage, 
minIndexCountPerBucket,
+                timeStepPerBucketSnapshotSegmentInMillis, 
maxIndexesPerBucketSnapshotSegment, maxNumBuckets);
+    }
+
+    public BucketDelayedDeliveryTracker(DelayedDeliveryContext context,
+                                        Timer timer, long tickTimeMillis,
+                                        boolean 
isDelayedDeliveryDeliverAtTimeStrict,
+                                        BucketSnapshotStorage 
bucketSnapshotStorage,
+                                        long minIndexCountPerBucket, long 
timeStepPerBucketSnapshotSegmentInMillis,
+                                        int 
maxIndexesPerBucketSnapshotSegment, int maxNumBuckets)
+            throws RecoverDelayedDeliveryTrackerException {
+        this(context, timer, tickTimeMillis, Clock.systemUTC(), 
isDelayedDeliveryDeliverAtTimeStrict,

Review Comment:
   done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to