nodece commented on code in PR #25384:
URL: https://github.com/apache/pulsar/pull/25384#discussion_r3032077244
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java:
##########
Review Comment:
No usage.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/BucketDelayedDeliveryTrackerFactory.java:
##########
@@ -99,7 +99,18 @@ public DelayedDeliveryTracker
newTracker(AbstractPersistentDispatcherMultipleCon
@VisibleForTesting
BucketDelayedDeliveryTracker
newTracker0(AbstractPersistentDispatcherMultipleConsumers dispatcher)
throws RecoverDelayedDeliveryTrackerException {
- return new BucketDelayedDeliveryTracker(dispatcher, timer,
tickTimeMillis,
+ DelayedDeliveryContext context = new
DispatcherDelayedDeliveryContext(dispatcher);
+ return new BucketDelayedDeliveryTracker(context, timer, tickTimeMillis,
+ isDelayedDeliveryDeliverAtTimeStrict, bucketSnapshotStorage,
delayedDeliveryMinIndexCountPerBucket,
+
TimeUnit.SECONDS.toMillis(delayedDeliveryMaxTimeStepPerBucketSnapshotSegmentSeconds),
+ delayedDeliveryMaxIndexesPerBucketSnapshotSegment,
delayedDeliveryMaxNumBuckets);
+ }
+
+ @VisibleForTesting
+ BucketDelayedDeliveryTracker newTracker0(String dispatcherName,
ManagedCursor cursor)
Review Comment:
No usage.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTrackerFactory.java:
##########
@@ -67,7 +68,15 @@ public DelayedDeliveryTracker
newTracker(AbstractPersistentDispatcherMultipleCon
@VisibleForTesting
Review Comment:
```suggestion
```
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java:
##########
@@ -68,15 +69,39 @@ public class InMemoryDelayedDeliveryTracker extends
AbstractDelayedDeliveryTrack
long tickTimeMillis,
boolean
isDelayedDeliveryDeliverAtTimeStrict,
long fixedDelayDetectionLookahead) {
- this(dispatcher, timer, tickTimeMillis, Clock.systemUTC(),
isDelayedDeliveryDeliverAtTimeStrict,
- fixedDelayDetectionLookahead);
+ this(new DispatcherDelayedDeliveryContext(dispatcher), timer,
tickTimeMillis, Clock.systemUTC(),
+ isDelayedDeliveryDeliverAtTimeStrict,
fixedDelayDetectionLookahead);
}
public
InMemoryDelayedDeliveryTracker(AbstractPersistentDispatcherMultipleConsumers
dispatcher, Timer timer,
Review Comment:
```suggestion
@VisibleForTesting
public
InMemoryDelayedDeliveryTracker(AbstractPersistentDispatcherMultipleConsumers
dispatcher, Timer timer,
```
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTrackerFactory.java:
##########
@@ -67,7 +68,15 @@ public DelayedDeliveryTracker
newTracker(AbstractPersistentDispatcherMultipleCon
@VisibleForTesting
InMemoryDelayedDeliveryTracker
newTracker0(AbstractPersistentDispatcherMultipleConsumers dispatcher) {
- return new InMemoryDelayedDeliveryTracker(dispatcher, timer,
tickTimeMillis,
+ DelayedDeliveryContext context = new
DispatcherDelayedDeliveryContext(dispatcher);
+ return new InMemoryDelayedDeliveryTracker(context, timer,
tickTimeMillis,
+ isDelayedDeliveryDeliverAtTimeStrict,
fixedDelayDetectionLookahead);
+ }
+
+ @VisibleForTesting
+ InMemoryDelayedDeliveryTracker newTracker0(String dispatcherName,
ManagedCursor cursor) {
Review Comment:
No usage.
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java:
##########
@@ -68,15 +69,39 @@ public class InMemoryDelayedDeliveryTracker extends
AbstractDelayedDeliveryTrack
long tickTimeMillis,
boolean
isDelayedDeliveryDeliverAtTimeStrict,
long fixedDelayDetectionLookahead) {
- this(dispatcher, timer, tickTimeMillis, Clock.systemUTC(),
isDelayedDeliveryDeliverAtTimeStrict,
- fixedDelayDetectionLookahead);
+ this(new DispatcherDelayedDeliveryContext(dispatcher), timer,
tickTimeMillis, Clock.systemUTC(),
+ isDelayedDeliveryDeliverAtTimeStrict,
fixedDelayDetectionLookahead);
}
public
InMemoryDelayedDeliveryTracker(AbstractPersistentDispatcherMultipleConsumers
dispatcher, Timer timer,
long tickTimeMillis, Clock clock,
boolean
isDelayedDeliveryDeliverAtTimeStrict,
long fixedDelayDetectionLookahead) {
- super(dispatcher, timer, tickTimeMillis, clock,
isDelayedDeliveryDeliverAtTimeStrict);
+ this(new DispatcherDelayedDeliveryContext(dispatcher), timer,
tickTimeMillis, clock,
+ isDelayedDeliveryDeliverAtTimeStrict,
fixedDelayDetectionLookahead);
+ }
+
+ public InMemoryDelayedDeliveryTracker(String dispatcherName, ManagedCursor
cursor, Timer timer,
+ long tickTimeMillis, Clock clock,
+ boolean
isDelayedDeliveryDeliverAtTimeStrict,
+ long fixedDelayDetectionLookahead) {
+ this(new NoopDelayedDeliveryContext(dispatcherName, cursor), timer,
tickTimeMillis, clock,
+ isDelayedDeliveryDeliverAtTimeStrict,
fixedDelayDetectionLookahead);
+ }
+
+ public InMemoryDelayedDeliveryTracker(DelayedDeliveryContext context,
Timer timer,
+ long tickTimeMillis,
+ boolean
isDelayedDeliveryDeliverAtTimeStrict,
+ long fixedDelayDetectionLookahead) {
+ this(context, timer, tickTimeMillis, Clock.systemUTC(),
+ isDelayedDeliveryDeliverAtTimeStrict,
fixedDelayDetectionLookahead);
+ }
+
+ public InMemoryDelayedDeliveryTracker(DelayedDeliveryContext context,
Timer timer,
Review Comment:
```suggestion
private InMemoryDelayedDeliveryTracker(DelayedDeliveryContext context,
Timer timer,
```
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/delayed/InMemoryDelayedDeliveryTracker.java:
##########
@@ -68,15 +69,39 @@ public class InMemoryDelayedDeliveryTracker extends
AbstractDelayedDeliveryTrack
long tickTimeMillis,
boolean
isDelayedDeliveryDeliverAtTimeStrict,
long fixedDelayDetectionLookahead) {
- this(dispatcher, timer, tickTimeMillis, Clock.systemUTC(),
isDelayedDeliveryDeliverAtTimeStrict,
- fixedDelayDetectionLookahead);
+ this(new DispatcherDelayedDeliveryContext(dispatcher), timer,
tickTimeMillis, Clock.systemUTC(),
+ isDelayedDeliveryDeliverAtTimeStrict,
fixedDelayDetectionLookahead);
}
public
InMemoryDelayedDeliveryTracker(AbstractPersistentDispatcherMultipleConsumers
dispatcher, Timer timer,
long tickTimeMillis, Clock clock,
boolean
isDelayedDeliveryDeliverAtTimeStrict,
long fixedDelayDetectionLookahead) {
- super(dispatcher, timer, tickTimeMillis, clock,
isDelayedDeliveryDeliverAtTimeStrict);
+ this(new DispatcherDelayedDeliveryContext(dispatcher), timer,
tickTimeMillis, clock,
+ isDelayedDeliveryDeliverAtTimeStrict,
fixedDelayDetectionLookahead);
+ }
+
+ public InMemoryDelayedDeliveryTracker(String dispatcherName, ManagedCursor
cursor, Timer timer,
Review Comment:
No usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
