BewareMyPower commented on code in PR #549:
URL: https://github.com/apache/pulsar-client-cpp/pull/549#discussion_r2993781264
##########
lib/ConsumerImpl.cc:
##########
@@ -1844,9 +1846,8 @@ void ConsumerImpl::seekAsyncInternal(long requestId,
const SharedBuffer& seek, c
LockGuard lock{mutex_};
seekStatus_ = SeekStatus::NOT_STARTED;
lastSeekArg_ = previousLastSeekArg;
- executor_->postWork([self,
callback{std::exchange(seekCallback_, std::nullopt).value()}]() {
- callback(ResultOk);
- });
+ executor_->postWork([self,
callback{std::exchange(seekCallback_, std::nullopt).value()},
+ result]() { callback(result); });
Review Comment:
It seems that this PR is no longer fixing
`testHasMessageAvailableAfterSeekToEnd` but just to propagate the correct error
from seek response. Could you update the PR title?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
