BewareMyPower commented on code in PR #549:
URL: https://github.com/apache/pulsar-client-cpp/pull/549#discussion_r2946309629
##########
lib/ConsumerImpl.cc:
##########
@@ -334,11 +334,11 @@ Result ConsumerImpl::handleCreateConsumer(const
ClientConnectionPtr& cnx, Result
return ResultAlreadyClosed;
}
- mutexLock.unlock();
- LOG_INFO(getName() << "Created consumer on broker " <<
cnx->cnxString());
incomingMessages_.clear();
possibleSendToDeadLetterTopicMessages_.clear();
backoff_.reset();
+ mutexLock.unlock();
+ LOG_INFO(getName() << "Created consumer on broker " <<
cnx->cnxString());
Review Comment:
This change still does not make sense. `incomingMessages_.clear()` is called
in `handleCreateConsumer`, which happens before completing the seek callback in
https://github.com/apache/pulsar-client-cpp/blob/1a39e5323a2ec07a10cb8dc8b9d4b1c1aea8d324/lib/ConsumerImpl.cc#L266-L277
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
