lnbest0707-uber commented on PR #14686: URL: https://github.com/apache/pinot/pull/14686#issuecomment-2682921049
> > `feature` `performance` #14592 > > Add a pre-download feature to enable "graceful" node replacement on Pinot. With this feature, during node replacement, admins would replace the old node (OD) to new node (NN) with the same instance id. Instead of bringing down the ON before starting up NN (which is required because there cannot be 2 nodes taking same helix id at the same time), admins could: > > > > 1. Start NN in "pre-download" mode by adding one more parameter to StartServerCommand, like: > > > > ``` > > PropertiesConfiguration properties = CommonsConfigurationUtils.fromPath(<config_path>); > > PredownloadScheduler predownloadScheduler = new PredownloadScheduler(properties); > > predownloadScheduler.start(); > > ``` > > > > > > > > > > > > > > > > > > > > > > > > > > 2. Waiting for NN "pre-download" complete with one of following conditions: > > > > * pre-download fully succeed > > * pre-download partially succeed but have retried enough times > > * pre-download failed in non-retriable mode > > * already waited for a max time period > > 3. Bring down the ON > > 4. Start NN in normal mode > > Does it mean the admin need to change the config again and restart the NN in step 4? Node config (xxx.properties) does not need to be changed. But admin has to shut down the NN's "pre-download" mode process and restart the node in "normal" mode. Also updated the PR description with more clarity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
