KKcorps commented on code in PR #14798:
URL: https://github.com/apache/pinot/pull/14798#discussion_r1914048474
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -543,13 +555,22 @@ private void commitSegmentMetadataInternal(String
realtimeTableName,
SegmentZKMetadata committingSegmentZKMetadata =
updateCommittingSegmentMetadata(realtimeTableName,
committingSegmentDescriptor, isStartMetadata);
+ // Used to inject failure for testing. RealtimeSegmentValidationManager
should be able to fix the
+ // segment that encounter failure at this stage of commit protocol.
+
FailureInjectionUtils.injectFailure(FailureInjectionUtils.FAULT_BEFORE_NEW_SEGMENT_METADATA_CREATION,
Review Comment:
A better way to inject failures for test can be to extends this
`PinotLLCRealtimeSegmentDataManager` that throws failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
