KKcorps commented on code in PR #14798:
URL: https://github.com/apache/pinot/pull/14798#discussion_r1914035164
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##########
@@ -884,7 +892,7 @@ public String uploadLLCSegment(
@ApiResponse(code = 404, message = "Table or segment not found",
response = ErrorInfo.class),
@ApiResponse(code = 400, message = "Bad request", response =
ErrorInfo.class)
})
- public TableLLCSegmentUploadResponse uploadLLCSegmentV2(
+ public String uploadLLCSegmentV2(
Review Comment:
Do not change this to String as it will not ensure backward compatibility.
If you need something, add a new param in `TableLLCSegmentUploadResponse`
itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
