vrajat commented on code in PR #13742:
URL: https://github.com/apache/pinot/pull/13742#discussion_r1889988655
##########
pinot-core/src/main/java/org/apache/pinot/core/transport/ServerRoutingInstance.java:
##########
@@ -23,43 +23,36 @@
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;
import javax.annotation.concurrent.ThreadSafe;
-import org.apache.pinot.spi.config.table.TableType;
import org.apache.pinot.spi.utils.CommonConstants.Helix;
/**
* The {@code ServerRoutingInstance} class represents the routing target
instance which contains the information of
- * hostname, port, and table type it serves.
- * <p>Different table types on same host and port are counted as different
instances. Therefore, one single Pinot Server
- * might be treated as two different routing target instances based on the
types of table it serves.
+ * hostname and port.
*/
@ThreadSafe
public final class ServerRoutingInstance {
- private static final String SHORT_OFFLINE_SUFFIX = "_O";
- private static final String SHORT_REALTIME_SUFFIX = "_R";
Review Comment:
Instead of removing the `TableType`, is another option to **add** table name
? Then the rest of the code after `QueryRunner` would work as is since this
code does not hard-code offline/realtime blocks ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
