Jackie-Jiang commented on code in PR #13742: URL: https://github.com/apache/pinot/pull/13742#discussion_r1844710197
########## pinot-common/src/main/java/org/apache/pinot/common/utils/request/BrokerRequestIdUtils.java: ########## @@ -0,0 +1,38 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.utils.request; + +public class BrokerRequestIdUtils { + public static final int TABLE_TYPE_OFFSET = 10; Review Comment: If the plan is to remove this request id special handling and make server return the physical table name in the final version, I'd suggest not introducing request id handling at first place. There are 2 ways to finish the migration: 1. Finish it in 2 releases: 1st release make server send back the table name; 2nd release change broker 2. Finish it in 1 release: Make server send back the table name, and use a broker config flag to control broker behavior. Only enable the flag when all servers are deployed Happy to jump on a call to get consensus -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
