abhioncbr commented on PR #14415: URL: https://github.com/apache/pinot/pull/14415#issuecomment-2525360194
> this seems right. From what I can tell, it's just code moving. > > curious why you're not doing `SparkSegmentGenerationJobRunner.java` and `SparkSegmentMetadataPushJobRunner.java`. Yes, it's just a common code movement; no change in logic. It's also there for `SparkSegmentMetadataPushJobRunner` ([reference](pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-base/src/main/java/org/apache/pinot/plugin/ingestion/batch/spark/common/BaseSparkSegmentMetadataPushJobRunner.java)). However, I am not able to find a common code pattern for `SparkSegmentGenerationJobRunner`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
