ankitsultana commented on code in PR #14506:
URL: https://github.com/apache/pinot/pull/14506#discussion_r1851302322
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##########
@@ -781,6 +781,7 @@ public String uploadLLCSegment(
String realtimeTableName,
@ApiParam(value = "Name of the segment", required = true)
@PathParam("segmentName") String segmentName,
@QueryParam("uploadTimeoutMs") @DefaultValue("-1") int timeoutMs,
+ @QueryParam("expectedCrc") @DefaultValue("-1") long expectedCrc,
Review Comment:
I think it might be better to add a new API that returns the CRC for a given
segment on the server.
That API could be used for a bunch of other things and it will also make the
deepstore upload retry task cleaner
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
