rohityadav1993 commented on code in PR #14494:
URL: https://github.com/apache/pinot/pull/14494#discussion_r1850381910
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -425,13 +426,14 @@ public SuccessResponse reloadSegment(
/**
* Helper method to find the existing table based on the given table name
(with or without type suffix) and segment
* name.
- * TODO: Real-time table might also contain uploaded segments (not with LLC
name), which is not handled here.
*/
private String getExistingTable(String tableName, String segmentName) {
TableType tableType =
TableNameBuilder.getTableTypeFromTableName(tableName);
if (tableType == null) {
// Derive table type from segment name if the given table name doesn't
have type suffix
- tableType = LLCSegmentName.isLLCSegment(segmentName) ?
TableType.REALTIME : TableType.OFFLINE;
Review Comment:
@ankitsultana, the implementation is similar to LLCSegment.isLLCSegment and
we have table name restriction to not use `__`.
```
Preconditions.checkArgument(!tableName.contains(TABLE_NAME_FORBIDDEN_SUBSTRING),
"'tableName' cannot contain double underscore ('__')");
```
It should be safe to assume this segment name will always mean a realtime
table(based on javadocs).
Additionally, I think we can add a restriction to only allow
`UploadedRealtimeSegmentName` for realtime tables to make these kind of segment
-> table type derivation safer. [draft PR: #14508]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
