yashmayya commented on code in PR #14495: URL: https://github.com/apache/pinot/pull/14495#discussion_r1850339957
########## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/MailboxSendNode.java: ########## @@ -28,7 +30,7 @@ public class MailboxSendNode extends BasePlanNode { - private final int _receiverStageId; + private final BitSet _receiverStages; Review Comment: > Originally I though about just changing the current field to add repeat, but it looks like that is problematic on numbers (see https://protobuf.dev/programming-guides/proto3/#updating). Ah, that's unfortunate, that's exactly what I was curious about. > Case 1. is impossible as long as we update servers before brokers (which AFAIK is the recommendation) The recommended order is controller -> broker -> server (https://docs.pinot.apache.org/operators/operating-pinot/upgrading-pinot-cluster). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org