gortiz commented on code in PR #14495:
URL: https://github.com/apache/pinot/pull/14495#discussion_r1850256883
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/MailboxSendNode.java:
##########
@@ -28,7 +30,7 @@
public class MailboxSendNode extends BasePlanNode {
- private final int _receiverStageId;
+ private final BitSet _receiverStages;
Review Comment:
We can discuss about that in the next PR, but the idea is to keep the
current proto field as it is and add a new one that will be a `repeat int32`
with a new field id. Originally I though about just changing the current field
to add `repeat`, but it looks like that is problematic on numbers (see
https://protobuf.dev/programming-guides/proto3/#updating).
Therefore the old field will be kept as it is (storing just a single value)
and the new one will be a list. There are two interesting cases:
1. An updated broker sends a multi sender to a not updated server.
2. A not updated broker sends a single sender to an updated server.
Case 1. is impossible as long as we update servers before brokers (which
AFAIK is the recommendation). Case 2 can be solved in the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
