davecromberge commented on code in PR #14373:
URL: https://github.com/apache/pinot/pull/14373#discussion_r1848063380
##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/aggregator/DistinctCountCPCSketchAggregator.java:
##########
@@ -30,7 +31,7 @@ public DistinctCountCPCSketchAggregator() {
}
@Override
- public Object aggregate(Object value1, Object value2) {
+ public Object aggregate(Object value1, Object value2, Map<String, String>
functionParameters) {
Review Comment:
I have limited understanding but it appears that this is fundamental to the
task configuration:
https://github.com/apache/pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/minion/PinotTaskConfig.java#L55-L57
This is where the task configuration is sourced and then parsed out based on
prefixes and postfixes. I agree that splitting strings in this manner is
cumbersome for complex parameters but don't quite see how to fit a JsonObject
into this framework. Do you have suggestions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
