jackluo923 commented on code in PR #14288:
URL: https://github.com/apache/pinot/pull/14288#discussion_r1835030704
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/forward/CLPMutableForwardIndexV2.java:
##########
@@ -226,11 +238,9 @@ public void setString(int docId, String value) {
* encoded message by replacing them with empty arrays, as Pinot does not
accept null values.
*
* @param clpEncodedMessage The {@link EncodedMessage} to append.
- * @throws IOException if an I/O error occurs during the appending process.
*/
- public void appendEncodedMessage(@NotNull EncodedMessage clpEncodedMessage)
- throws IOException {
- if (_isClpEncoded) {
+ public void appendEncodedMessage(@NotNull EncodedMessage clpEncodedMessage) {
+ if (_isClpEncoded || _forceEnableClpEncoding) {
Review Comment:
It is triggered when `setForceEnableClpEncoding(boolean cond)` is called
with the `true` value. Since CLPMutableForwardIndexV2 is expected to replace
CLPMutableForwardIndex (V1) in the OSS code, we need this option to always
enable CLP Encoding regardless of dictionary size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
