Jackie-Jiang commented on code in PR #14440:
URL: https://github.com/apache/pinot/pull/14440#discussion_r1842792247
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseCombineOperator.java:
##########
@@ -180,4 +181,20 @@ public List<Operator> getChildOperators() {
* Invoked when {@link #processSegments()} is finished (called in the
finally block).
*/
protected abstract void onProcessSegmentsFinish();
+
+ protected static void onOperatorException(Operator operator, Exception e) {
Review Comment:
Let's call it `wrapOperatorException()` and return `RuntimeException` so
that we can directly throw it out in the caller. Currently it is a little bit
hard to read because exception can be thrown in 2 places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
