Jackie-Jiang commented on code in PR #14440: URL: https://github.com/apache/pinot/pull/14440#discussion_r1841356093
########## pinot-core/src/main/java/org/apache/pinot/core/operator/combine/BaseSingleBlockCombineOperator.java: ########## @@ -92,6 +92,9 @@ protected void processSegments() { ((AcquireReleaseColumnsSegmentOperator) operator).acquire(); } resultsBlock = (T) operator.nextBlock(); + } catch (Exception e) { + onProcessError(operator, e); Review Comment: Should we consider wrapping it with exception message with segment name instead of logging? Currently it will cause duplicate log because we will log again when catching the exception -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org