ankitsultana commented on code in PR #14413:
URL: https://github.com/apache/pinot/pull/14413#discussion_r1835156910
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/timeseries/TimeSeriesAggregationOperator.java:
##########
@@ -240,14 +242,12 @@ public void processStringExpression(BlockValSet
blockValSet, Map<Long, BaseTimeS
}
}
- public static long[] applyTimeshift(long timeshift, long[] timeValues, int
numDocs) {
- if (timeshift == 0) {
- return timeValues;
+ private void applyTimeOffset(long[] timeValues, int numDocs) {
Review Comment:
We also do the time-shift in-place instead of allocating another array.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
