ankitsultana opened a new pull request, #14413: URL: https://github.com/apache/pinot/pull/14413
At present, our time buckets are half open on the right. This leads to very weird semantics in visualizations like in Grafana. This PR changes those semantics to make the buckets half open on the left. To explain with an example, if we have the following values in TimeBuckets: ``` TimeBuckets = [10_000, 10_100, 10_200, 10_300] ``` Then the time range that maps to each of the values above are: ``` (9_000, 10_000] (10_000, 10_100] (10_100, 10_200] (10_200, 10_300] ``` **Other Changes** * Renamed the TimeBuckets methods to make the semantics clearer. * Added some UTs * Made a minor optimization in how timeshift is applied, by getting rid of an unnecessary allocation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
