gortiz commented on code in PR #14296: URL: https://github.com/apache/pinot/pull/14296#discussion_r1816145901
########## pinot-query-planner/src/main/java/org/apache/pinot/query/planner/plannode/PlanNodeVisitor.java: ########## @@ -63,4 +63,150 @@ public interface PlanNodeVisitor<T, C> { T visitExchange(ExchangeNode exchangeNode, C context); T visitExplained(ExplainedNode node, C context); + + /** Review Comment: Because it is closely related to this visitor. Also I don't need to call it `PlanNodeDepthFirstVisitor` given it is already contained inside `PlanNodeVisitor`. But I'm open to move as a regular class if it is preferred. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org