gortiz commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1808247224
########## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ########## @@ -81,15 +81,31 @@ public class HelixExternalViewBasedQueryQuotaManager implements ClusterChangeHan private final AtomicInteger _lastKnownBrokerResourceVersion = new AtomicInteger(-1); private final Map<String, QueryQuotaEntity> _rateLimiterMap = new ConcurrentHashMap<>(); private final Map<String, QueryQuotaEntity> _databaseRateLimiterMap = new ConcurrentHashMap<>(); + private final Map<String, QueryQuotaEntity> _applicationRateLimiterMap = new ConcurrentHashMap<>(); private double _defaultQpsQuotaForDatabase; + private double _defaultQpsQuotaForApplication; private HelixManager _helixManager; private ZkHelixPropertyStore<ZNRecord> _propertyStore; private volatile boolean _queryRateLimitDisabled; + private final RateLimiterFactory _rateLimiterFactory; Review Comment: Please annotate it win `@Nullable` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
