bziobrowski commented on code in PR #14226: URL: https://github.com/apache/pinot/pull/14226#discussion_r1807474217
########## pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java: ########## @@ -81,15 +81,32 @@ public class HelixExternalViewBasedQueryQuotaManager implements ClusterChangeHan private final AtomicInteger _lastKnownBrokerResourceVersion = new AtomicInteger(-1); private final Map<String, QueryQuotaEntity> _rateLimiterMap = new ConcurrentHashMap<>(); private final Map<String, QueryQuotaEntity> _databaseRateLimiterMap = new ConcurrentHashMap<>(); + private final Map<String, QueryQuotaEntity> _applicationRateLimiterMap = new ConcurrentHashMap<>(); private double _defaultQpsQuotaForDatabase; + private double _defaultQpsQuotaForApplication; Review Comment: It's a cluster-level default for all applications that don't have an explicit value set. e.g. if we have default app quota = 10 'test' app quota = 20 Then queries with 'test' applicationName option will be limited to 20 qps while 'other' or 'app_ricot' will be limited to 10 even though they don't have an explicit mapping/value set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
