bziobrowski commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1807473107


##########
pinot-controller/pom.xml:
##########
@@ -166,5 +167,41 @@
         <npm.script>build</npm.script>
       </properties>
     </profile>
+    <profile>
+      <id>pinot-fastdev</id>
+      <build>
+        <plugins>
+          <plugin>
+            <groupId>org.codehaus.mojo</groupId>
+            <artifactId>build-helper-maven-plugin</artifactId>
+            <version>3.6.0</version>
+            <executions>
+              <execution>
+                <id>check-frontend-up-to-date</id>
+                <phase>process-sources</phase>
+                <goals>
+                  <goal>uptodate-property</goal>
+                </goals>
+                <configuration>

Review Comment:
   This approach, while useful, isn't bulletproof. 
   If one switches between branches then it won't trigger build if files in 
current branch are older than in the previous one. 
   Still, it's better than checking whether target file exists. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to