gortiz commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1806508454
##########
pom.xml:
##########
@@ -294,6 +296,9 @@
<rat.skip>true</rat.skip>
<spotless.check.skip>true</spotless.check.skip>
<shade.phase.prop>none</shade.phase.prop>
+ <archiver.compress>false</archiver.compress>
+ <archiver.recompressZippedFiles>false</archiver.recompressZippedFiles>
+ <npm.command>install --no-audit</npm.command>
Review Comment:
I don't think we should run `install` by default. It is unsafe to update
dependencies. And with the usage of build-helper:uptodate-property it shouldn't
be problematic if pinot-fastdev profile is enabled, am I right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
