ege-st commented on code in PR #14197:
URL: https://github.com/apache/pinot/pull/14197#discussion_r1794403121
##########
pinot-core/src/test/java/org/apache/pinot/core/data/function/GroovyFunctionEvaluatorTest.java:
##########
@@ -23,17 +23,55 @@
import java.util.List;
import java.util.Map;
import org.apache.pinot.segment.local.function.GroovyFunctionEvaluator;
+import org.apache.pinot.segment.local.function.GroovyStaticAnalyzerConfig;
import org.apache.pinot.spi.data.readers.GenericRow;
import org.testng.Assert;
import org.testng.annotations.DataProvider;
import org.testng.annotations.Test;
import org.testng.collections.Lists;
+import static
org.apache.pinot.segment.local.function.GroovyStaticAnalyzerConfig.getDefaultAllowedImports;
+import static
org.apache.pinot.segment.local.function.GroovyStaticAnalyzerConfig.getDefaultAllowedReceivers;
+
/**
* Tests Groovy functions for transforming schema columns
*/
public class GroovyFunctionEvaluatorTest {
+ @Test
+ public void testIllegalGroovyScripts() {
+ // TODO: Add separate tests for these rules: receivers, imports, static
imports, and method names.
+ List<String> scripts = List.of(
+ "Groovy({\"ls\".execute()})",
+ "Groovy({[\"ls\"].execute()})",
+ "Groovy({System.exit(5)})",
+ "Groovy({System.metaClass.methods.each { method -> if
(method.name.md5() == "
+ + "\"f24f62eeb789199b9b2e467df3b1876b\") {method.invoke(System,
10)} }})",
+ "Groovy({System.metaClass.methods.each { method -> if
(method.name.reverse() == (\"ti\" + \"xe\")) "
+ + "{method.invoke(System, 10)} }})",
+ "groovy({def args = [\"QuickStart\", \"-type\", \"REALTIME\"] as
String[]; "
+ + "org.apache.pinot.tools.admin.PinotAdministrator.main(args);
2})",
+ "Groovy({return [\"bash\", \"-c\", \"env\"].execute().text})"
+ );
+
+ final GroovyStaticAnalyzerConfig config = new GroovyStaticAnalyzerConfig(
Review Comment:
Just working shopping how an immutable by default approach to Java would
work, I'll get rid of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
