jackjlli commented on PR #14014: URL: https://github.com/apache/pinot/pull/14014#issuecomment-2359616078
> Hmm.. I think this change is backward incompatible. But I'm +100 on making it optional. @jackjlli do you use this field internally? Yes, this field is actively being used internally, so it's a `required` field for LinkedIn use cases. But it should make no harm to make it optional. @ashishjayamohan what's the rational of making it optional? If there is nothing specified in it, it shouldn't occupy too much space though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
