klsince commented on code in PR #13914:
URL: https://github.com/apache/pinot/pull/13914#discussion_r1761999187
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManagerForConsistentDeletes.java:
##########
@@ -81,6 +85,12 @@ protected long getNumPrimaryKeys() {
protected void doAddOrReplaceSegment(ImmutableSegmentImpl segment,
ThreadSafeMutableRoaringBitmap validDocIds,
@Nullable ThreadSafeMutableRoaringBitmap queryableDocIds,
Iterator<RecordInfo> recordInfoIterator,
@Nullable IndexSegment oldSegment, @Nullable MutableRoaringBitmap
validDocIdsForOldSegment) {
+ if (_partialUpsertHandler == null) {
+ // for full upsert, we are de-duping primary key once here to make sure
that we are not adding
+ // primary-key multiple times and subtracting just once in removeSegment.
+ // for partial-upsert, we call this method in base class.
+ recordInfoIterator = resolveComparisonTies(recordInfoIterator,
_hashFunction);
Review Comment:
👍 make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
