tibrewalpratik17 commented on code in PR #13914:
URL: https://github.com/apache/pinot/pull/13914#discussion_r1761969294
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -544,9 +544,7 @@ public void addSegment(ImmutableSegmentImpl segment,
@Nullable ThreadSafeMutable
protected void addOrReplaceSegment(ImmutableSegmentImpl segment,
ThreadSafeMutableRoaringBitmap validDocIds,
@Nullable ThreadSafeMutableRoaringBitmap queryableDocIds,
Iterator<RecordInfo> recordInfoIterator,
@Nullable IndexSegment oldSegment, @Nullable MutableRoaringBitmap
validDocIdsForOldSegment) {
- if (_partialUpsertHandler != null) {
Review Comment:
Done! I had to move this inside the sub-class as i realised why I added
this! For full-upsert, if we don't call `resolveComparisonTies` then we might
end-up incrementing the segment-count multiple times but decreasing it only
once during `replaceSegment` flow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
