suvodeep-pyne commented on code in PR #13913:
URL: https://github.com/apache/pinot/pull/13913#discussion_r1739177803
##########
pinot-plugins/pinot-input-format/pinot-csv/src/test/java/org/apache/pinot/plugin/inputformat/csv/CSVRecordReaderTest.java:
##########
@@ -324,6 +324,47 @@ public void
testLineIteratorReadingDataFileWithUnparseableLines()
Assert.assertEquals(1, genericRows.size());
}
+ @Test
+ public void testLineIteratorReadingDataFileWithUnparseableLinesWithRewind()
+ throws URISyntaxException, IOException {
+ URI uri =
ClassLoader.getSystemResource("dataFileWithUnparseableLines2.csv").toURI();
+ File dataFile = new File(uri);
+
+ CSVRecordReaderConfig readerConfig = new CSVRecordReaderConfig();
+ readerConfig.setSkipUnParseableLines(true);
+ final List<GenericRow> genericRows1 = readCSVRecords(dataFile,
readerConfig, null, false);
Review Comment:
@swaminathanmanish
I was wrong about this. It doesn't `rewind()`. And it doesn't matter because
`readCSVRecords()` does an `init()` before reading. That's why the test is
passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
