gortiz commented on code in PR #13839:
URL: https://github.com/apache/pinot/pull/13839#discussion_r1721609548
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##########
@@ -1002,7 +1002,8 @@ static void validatePartialUpsertStrategies(TableConfig
tableConfig, Schema sche
return;
}
-
Preconditions.checkState(tableConfig.getIndexingConfig().isNullHandlingEnabled(),
+ Preconditions.checkState(schema.isEnableColumnBasedNullHandling()
+ || tableConfig.getIndexingConfig().isNullHandlingEnabled(),
Review Comment:
This is the other change that changes semantic. Before this change partial
upserts were not accepted when column based null handling was enabled but table
based was disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
