sajjad-moradi commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1723577774
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PauseStatus.java:
##########
@@ -22,20 +22,27 @@
import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
import java.util.Set;
+import org.apache.pinot.spi.config.table.TablePauseStatus;
@JsonInclude(JsonInclude.Include.NON_NULL)
public class PauseStatus {
private boolean _pauseFlag;
private Set<String> _consumingSegments;
+ private TablePauseStatus.ReasonCode _reasonCode;
+ private String _comment;
private String _description;
Review Comment:
Sorry I conflated the two objects here. What do you think of:
- We definitely need two separate objects (as you are proposing): one used
in ideal state and one as the response of /pauseStatus endpoint
- We can name the ideal state object as `PauseState`
- We can name the api response object as `PauseStatusDetails` which
basically decorates `PauseState` object with more information like list of
consuming segments, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
