deemoliu commented on code in PR #13636: URL: https://github.com/apache/pinot/pull/13636#discussion_r1683335333
########## pinot-spi/src/main/java/org/apache/pinot/spi/config/table/DedupConfig.java: ########## @@ -52,4 +61,8 @@ public boolean isDedupEnabled() { public String getMetadataManagerClass() { return _metadataManagerClass; } + + public double getMetadataTTL() { Review Comment: this won't work for dedupManager since there is no support for removeExpiredPrimaryKey functionalities in the dedupPartitionManager. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org