jtao15 commented on code in PR #13636:
URL: https://github.com/apache/pinot/pull/13636#discussion_r1691603911
##########
pinot-spi/src/main/java/org/apache/pinot/spi/config/table/DedupConfig.java:
##########
@@ -20,25 +20,34 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonPropertyDescription;
import org.apache.pinot.spi.config.BaseJsonConfig;
public class DedupConfig extends BaseJsonConfig {
+ @JsonPropertyDescription("Whether dedup is enabled or not.")
private final boolean _dedupEnabled;
+ @JsonPropertyDescription("Function to hash the primary key.")
private final HashFunction _hashFunction;
+ @JsonPropertyDescription("Custom class for dedup metadata manager.")
private final String _metadataManagerClass;
+ @JsonPropertyDescription("Whether to use TTL for dedup metadata cleanup, it
uses the same unit as the time column.")
+ private final double _metadataTTL;
Review Comment:
Just curious, would it be more readable if we use a string for the TTL
(e.g., '1 day') or introduce two fields: one for the time value and one for the
time unit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
