itschrispeck commented on PR #13541: URL: https://github.com/apache/pinot/pull/13541#issuecomment-2231869927
> I don't fully follow the change. When there is no partition assigned to the given instance, the loop should all be skipped, and it should return GOOD right? Not sure I understand, are you referring to [this loop](https://github.com/apache/pinot/blob/cf1a0f6b9b44fdb567452b63a34e76ac5c635429/pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java#L446-L468)? If so, the if condition linked in the PR description shows that it will return `STARTING` status if the current state is null Or if you mean the [outer loop](https://github.com/apache/pinot/blob/cf1a0f6b9b44fdb567452b63a34e76ac5c635429/pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java#L368-L387), the issue is that `_resourceIterator` collected all assigned resources when the server first started up. The resources being iterated through are not necessarily still assigned to the server, and should be re-evaluated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
