jtao15 commented on code in PR #13541:
URL: https://github.com/apache/pinot/pull/13541#discussion_r1670520235
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java:
##########
@@ -443,8 +467,9 @@ private StatusDescriptionPair evaluateResourceStatus(String
resourceName) {
// external view or went to ERROR state (which means that we tried to
load the segments/resources but failed for
// some reason)
Map<String, String> partitionStateMap = getPartitionStateMap(helixState);
- for (String partitionName : idealState.getPartitionSet()) {
- String idealStateStatus =
idealState.getInstanceStateMap(partitionName).get(_instanceName);
+ for (String partitionName : partitionSet) {
+ String idealStateStatus =
partitionToIdealStateStatusMap.getOrDefault(partitionName,
+ idealState.getInstanceStateMap(partitionName).get(_instanceName));
Review Comment:
(nit) We can just use get() instead of getOrDefault() since the map value
has been set as
`idealState.getInstanceStateMap(partitionName).get(_instanceName)` on L448?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
