abhioncbr commented on code in PR #13380:
URL: https://github.com/apache/pinot/pull/13380#discussion_r1642427576
##########
helm/pinot/templates/_helpers.tpl:
##########
@@ -319,3 +319,14 @@ The name of the pinot minion stateless config.
{{- define "pinot.minionStateless.config" -}}
{{- printf "%s-config" (include "pinot.minionStateless.fullname" .) | trunc 63
| trimSuffix "-" -}}
{{- end -}}
+
+{{/*
+Return pinot namespace to use
+*/}}
+{{- define "pinot.namespace" -}}
+{{- if .Values.namespaceOverride -}}
+ {{- .Values.namespaceOverride -}}
+{{- else -}}
+ {{- .Release.Namespace -}}
Review Comment:
Here is the behaviour
- If the `namespaceOverride` value is provided, it will precede the rest.
- If the `namespaceOverride` value is not provided, and we use the helm
command with `-n <value>`, the provided value in the command will get used.
- If both the above values are not provided, then the `default` value will
be set as a namespace.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
