rohityadav1993 commented on code in PR #13107: URL: https://github.com/apache/pinot/pull/13107#discussion_r1619054555
########## pinot-common/src/main/java/org/apache/pinot/common/utils/UploadedRealtimeSegmentName.java: ########## @@ -0,0 +1,131 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.common.utils; + +import com.google.common.base.Preconditions; +import java.util.Objects; +import java.util.regex.Matcher; +import java.util.regex.Pattern; + + +/** + * Class to represent segment names like: uploaded_{tableName}_{partitionId}_{sequenceId}_{creationTime} + * + * This naming convention is adopted to represent a batch generated segment uploaded to a realtime table. The naming + * convention has been kept different from {@LLCSegmentName} to differentiate between batch generated segments and + * low level consumer segments. + */ +public class UploadedRealtimeSegmentName implements Comparable<UploadedRealtimeSegmentName> { + + public static final String UPLOADED_REALTIME_SEGMENT_NAME_REGEX = "^uploaded_(.+)_(\\d+)_(\\d+)_(\\d+)$"; Review Comment: @klsince, I see LLC segment name does not validate the integer and long fields encoded in name: ``` public static boolean isLLCSegment(String segmentName) { int numSeparators = 0; int index = 0; while ((index = segmentName.indexOf(SEPARATOR, index)) != -1) { numSeparators++; index += 2; // SEPARATOR.length() } return numSeparators == 3; } ``` We can have a similar string split based checks and parsing for uniformity but I think it would be good to validate the int and long fields as well, as they get used later in the code, the changes would look like this. ``` public UploadedRealtimeSegmentName(String segmentName) { // split the segment name by the separator and get creation time, sequence id, partition id and table name from // the end and validate segment name starts with prefix uploaded_ try { String[] parts = segmentName.split(SEPARATOR); Preconditions.checkState(parts.length >= 5 && parts[0].equals(UPLOADED_PREFIX), "Uploaded segment name must be of the format uploaded_{tableName}_{partitionId}_{sequenceId}_{creationTime}"); _creationTime = Long.parseLong(parts[parts.length - 1]); _sequenceId = Integer.parseInt(parts[parts.length - 2]); _partitionId = Integer.parseInt(parts[parts.length - 3]); _tableName = Joiner.on(SEPARATOR).join(Arrays.copyOfRange(parts, 1, parts.length - 3)); _segmentName = segmentName; } catch (NumberFormatException e) { throw new IllegalArgumentException("Invalid segment name: " + segmentName, e); } } ``` ``` public static boolean isUploadedRealtimeSegmentName(String segmentName) { String[] parts = segmentName.split(SEPARATOR); if(parts.length < 5) { return false; } if (!parts[0].equals(UPLOADED_PREFIX)) { return false; } // return false if parts[-1] is not an integer try { Long.parseLong(parts[parts.length - 1]); Integer.parseInt(parts[parts.length - 2]); Integer.parseInt(parts[parts.length - 3]); } catch (NumberFormatException e) { return false; } return true; } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
