klsince commented on code in PR #13107:
URL: https://github.com/apache/pinot/pull/13107#discussion_r1618004659
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/SegmentUtils.java:
##########
@@ -44,6 +44,16 @@ public static Integer getRealtimeSegmentPartitionId(String
segmentName, String r
if (llcSegmentName != null) {
return llcSegmentName.getPartitionGroupId();
}
+
+ try {
+ UploadedRealtimeSegmentName uploadedRealtimeSegmentName = new
UploadedRealtimeSegmentName(segmentName);
Review Comment:
we may add a util method UploadedRealtimeSegmentName.of(segmentName) like
LLCSegmentName.of()
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/UploadedRealtimeSegmentName.java:
##########
@@ -0,0 +1,131 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.utils;
+
+import com.google.common.base.Preconditions;
+import java.util.Objects;
+import java.util.regex.Matcher;
+import java.util.regex.Pattern;
+
+
+/**
+ * Class to represent segment names like:
uploaded_{tableName}_{partitionId}_{sequenceId}_{creationTime}
+ *
+ * This naming convention is adopted to represent a batch generated segment
uploaded to a realtime table. The naming
+ * convention has been kept different from {@LLCSegmentName} to differentiate
between batch generated segments and
+ * low level consumer segments.
+ */
+public class UploadedRealtimeSegmentName implements
Comparable<UploadedRealtimeSegmentName> {
+
+ public static final String UPLOADED_REALTIME_SEGMENT_NAME_REGEX =
"^uploaded_(.+)_(\\d+)_(\\d+)_(\\d+)$";
Review Comment:
hmm. why not just split the fields out from the segment name via
StringUtils.split()? In case the table name might include `_`, we can get the
required fields as counted from the end of name. And for simplicity, we can
enforce to have `seqId` field (which seems optional in this regex pattern).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
