KKcorps commented on code in PR #13112:
URL: https://github.com/apache/pinot/pull/13112#discussion_r1599433245
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisPartitionGroupOffset.java:
##########
@@ -40,10 +40,20 @@
public class KinesisPartitionGroupOffset implements StreamPartitionMsgOffset {
private final String _shardId;
private final String _sequenceNumber;
+ private final OffsetStartStatus _startStatus;
Review Comment:
This was a miss. Made the change.
I have ensured backward compatibility so for old table we don't need to
worry. the start status would always be RESUME for them which is the current
behavior as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
