gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1576220503
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/TransferableBlock.java:
##########
@@ -19,44 +19,50 @@
package org.apache.pinot.query.runtime.blocks;
import com.google.common.base.Preconditions;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
+import javax.annotation.Nullable;
import org.apache.pinot.common.datablock.ColumnarDataBlock;
import org.apache.pinot.common.datablock.DataBlock;
import org.apache.pinot.common.datablock.DataBlockUtils;
import org.apache.pinot.common.datablock.MetadataBlock;
import org.apache.pinot.common.datablock.RowDataBlock;
-import org.apache.pinot.common.response.ProcessingException;
import org.apache.pinot.common.utils.DataSchema;
import org.apache.pinot.core.common.Block;
import org.apache.pinot.core.common.datablock.DataBlockBuilder;
import org.apache.pinot.core.util.DataBlockExtractUtils;
-import org.apache.pinot.query.runtime.operator.OperatorStats;
-import org.apache.pinot.query.runtime.operator.utils.OperatorUtils;
-
+import org.apache.pinot.query.runtime.plan.MultiStageQueryStats;
/**
* A {@code TransferableBlock} is a wrapper around {@link DataBlock} for
transferring data using
* {@link org.apache.pinot.common.proto.Mailbox}.
*/
public class TransferableBlock implements Block {
private final DataBlock.Type _type;
+ @Nullable
private final DataSchema _dataSchema;
private final int _numRows;
private List<Object[]> _container;
private DataBlock _dataBlock;
private Map<Integer, String> _errCodeToExceptionMap;
+ @Nullable
+ private final MultiStageQueryStats _queryStats;
- public TransferableBlock(List<Object[]> container, DataSchema dataSchema,
DataBlock.Type type) {
+ public TransferableBlock(List<Object[]> container, @Nullable DataSchema
dataSchema, DataBlock.Type type) {
Review Comment:
I don't remember where, but I've found a path in the code this method could
be called with a null data schema.
I may also be wrong, maybe I've just found that call during my debugs in a
moment there was an error in my code. I guess I can remove the annotation and
just add it again in case I find the problematic call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
