gortiz commented on code in PR #12704:
URL: https://github.com/apache/pinot/pull/12704#discussion_r1576184899
##########
pinot-common/src/main/java/org/apache/pinot/common/response/broker/BrokerResponseNative.java:
##########
@@ -51,6 +59,7 @@
"segmentStatistics", "traceInfo", "partialResult"
})
public class BrokerResponseNative implements BrokerResponse {
Review Comment:
The main reason to modify this file is to have an easier way to merge the
stats from V2 into V1. Basically BrokerResponseNative exports the V1 metrics
into a different format. In order to make it easy to populate these stats from
V2 (mainly from leaf stage) I've modified `BrokerResponseNative` to be store a
StatMap inside. The difference is very small (mostly change setters and
getters) but it ends up being closer to an ideal state where all these metrics
are stored in the same way.
I guess I can remove this change, but then
`MultiStageOperator.Type.LEAF.mergeInto(BrokerResponseNativeV2 response, ,
StatMap<?> map)`. I can take to follow that approach given it doesn't look you
like the idea of touching this class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
