jadami10 commented on issue #12635: URL: https://github.com/apache/pinot/issues/12635#issuecomment-2063876271
Here's my understanding of what is valid, what the original function does, and what your new function does. | dictEnabledColumn | invertedIndex | is valid | "dictEnabledColumn or !originalConfig.getConfig(StandardIndexes.inverted()).isEnabled() | "!originalConfig.getConfig(StandardIndexes.inverted()).isEnabled() or !dictEnabledColumn" | | --- | --- | --- | --- | --- | | true | true | true | true | false | | true | false | true | true | true | | false | false | true | true | true | | false | true | false | false | true | I believe the original check is correct based on the table above. It specifically only fails when we're not creating a dictionary for the column but want the inverted index. > Since inverted index support it, it would return true. In json and text indexes we are not enabling dictionary support for better storage capabilities I imagine. Inverted indices don't just support the dictionary index, they actively require it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
